villebro commented on code in PR #25947:
URL: https://github.com/apache/superset/pull/25947#discussion_r1389940149
##########
setup.py:
##########
@@ -84,7 +84,7 @@ def get_git_sha() -> str:
"deprecation>=2.1.0, <2.2.0",
"flask>=2.2.5, <3.0.0",
"flask-appbuilder>=4.3.9, <5.0.0",
- "flask-caching>=1.11.1, <2.0",
+ "flask-caching>=2.0, <3",
Review Comment:
Minor comment: I think it's been customary to set the lower bound to the
version we're locking to in the requirements. I would maybe consider doing the
following, unless there's strong feelings about the need for supporting
`>=2.0.0, <2.1`
```suggestion
"flask-caching>=2.1.0, <3",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
