zephyring commented on code in PR #26140:
URL: https://github.com/apache/superset/pull/26140#discussion_r1410010301
##########
superset-frontend/src/components/Chart/chartAction.js:
##########
@@ -269,9 +269,13 @@ export function runAnnotationQuery({
return Promise.resolve();
}
- const granularity = fd.time_grain_sqla || fd.granularity;
- fd.time_grain_sqla = granularity;
- fd.granularity = granularity;
+ // remap from controls to formData naming; in the original formData the
+ // `granularity` attribute represents the time grain, but in the request
+ // payload it corresponds to the name of the column where the time grain
+ // should be applied...
Review Comment:
it will be helpful to add sample data for time_grain and granularity as
inline comment. .e.g
original `granularity` can be `P1D` but in request payload expect to be
column name like `Date`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
