rtexelm commented on code in PR #25894:
URL: https://github.com/apache/superset/pull/25894#discussion_r1410954839


##########
superset/reports/notifications/slack.py:
##########
@@ -59,8 +60,11 @@ class SlackNotification(BaseNotification):  # pylint: 
disable=too-few-public-met
 
     type = ReportRecipientType.SLACK
 
+    # Use utils function to parse & format recipients
     def _get_channel(self) -> str:

Review Comment:
   Certainly, I'll add this in now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to