kasiazjc commented on PR #25734: URL: https://github.com/apache/superset/pull/25734#issuecomment-1834175720
> > Question about the height - will it always fill the screen or depends on the content? I am a designer, so not sure how some of the properties do work > > @kasiazjc it will depend on the content. As you can see on the screenshots of the main comment, the modal maintains the current explicit height on the Metrics tab. It only expands on the Columns tab, which is larger. Thanks! I think it should have the same, fixed height on all of the columns - changing the height of the modal in general is a bad UX pattern (for example action buttons/footer change place etc which can be confusing). I would suggest setting the height of the modal to for example 80% screen height for all of the tabs to maintain consistent behavior between the tabs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
