CorbinBullard opened a new pull request, #26151:
URL: https://github.com/apache/superset/pull/26151

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   - Can no longer clear/remove the row limit
   - New validator that checks if a value is larger than a given input
   - **Removed ValidateNonEmpty() validator that was causing charts before the 
update not to render**
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Before:
   ![Row Limit 
1](https://github.com/apache/superset/assets/11916151/fabe72b1-4b60-4c53-a3b6-52a252e1e3f9)
   ![Row Limit 
2](https://github.com/apache/superset/assets/11916151/80217f0f-27c3-41a7-893a-ab79b47ac68d)
   After:
   ![Screenshot 2023-10-09 
120420](https://github.com/apache/superset/assets/11916151/3a5bac51-6064-40db-8884-9f70d4546b5c)
   ![Screenshot 2023-10-09 
120447](https://github.com/apache/superset/assets/11916151/d614cb74-70d3-4466-8623-e93e5b7ea107)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to