john-bodley commented on code in PR #26082:
URL: https://github.com/apache/superset/pull/26082#discussion_r1411464225
##########
setup.py:
##########
@@ -143,6 +143,7 @@ def get_git_sha() -> str:
"google-cloud-bigquery>=3.10.0",
],
"clickhouse": ["clickhouse-connect>=0.5.14, <1.0"],
+ "databend": ["databend-sqlalchemy>=0.3.2, <0.5"],
Review Comment:
@hantmac per [PyPI](https://pypi.org/project/databend-sqlalchemy/#history)
the latest release of said package is `0.3.2` and thus the open upper limit of
`0.5` seems somewhat arbitrary. Generally—assuming that the package is adhering
to semver—placing an open upper limit of the major version (in this case `1.0`)
is preferred as this _should_ prevent breaking changes.
##########
setup.py:
##########
@@ -143,6 +143,7 @@ def get_git_sha() -> str:
"google-cloud-bigquery>=3.10.0",
],
"clickhouse": ["clickhouse-connect>=0.5.14, <1.0"],
+ "databend": ["databend-sqlalchemy>=0.3.2, <0.5"],
Review Comment:
@hantmac per [PyPI](https://pypi.org/project/databend-sqlalchemy/#history)
the latest release of said package is `0.3.2` and thus the open upper limit of
`0.5` seems somewhat arbitrary. Generally—assuming that the package is adhering
to semver—placing an open upper limit of the major version (in this case `1.0`)
is preferred as this _should_ prevent breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
