john-bodley commented on code in PR #26189:
URL: https://github.com/apache/superset/pull/26189#discussion_r1418025453
##########
superset-frontend/src/components/DynamicEditableTitle/index.tsx:
##########
@@ -113,10 +113,12 @@ export const DynamicEditableTitle = ({
// then we can measure the width of that span to resize the input element
useLayoutEffect(() => {
if (sizerRef?.current) {
- sizerRef.current.innerHTML = (currentTitle || placeholder).replace(
- /\s/g,
- ' ',
- );
+ sizerRef.current.innerHTML = (currentTitle || placeholder)
Review Comment:
Sorry I meant escape rather than sanitize. It
[seems](https://github.com/search?q=repo%3Aapache%2Fsuperset%20escape-html&type=code)
like we're already installing the `escape-html` library and thus maybe we
should just use that directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
