kgabryje opened a new pull request, #26340: URL: https://github.com/apache/superset/pull/26340
### SUMMARY When user performed an action that caused `directPathToChild` to point to an element outside of `DashboardContainer` (such as clicking on applied native filter's name in chart's header to highlight the native filter), it caused the tabs to switch to the first tab. This PR fixes that behaviour to instead remain on current tab. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://github.com/apache/superset/assets/15073128/0ff04c0c-c3ed-43d9-a061-438c72a7dd61 After: https://github.com/apache/superset/assets/15073128/90e25fa9-0203-4c7a-867b-1578a3310753 ### TESTING INSTRUCTIONS 1. Create a dashboard with tabs 2. Apply some native filters, go to a chart in 2nd tab and click on filter's name in filters badge 3. Verify that the native filter got highlighted, but the tab didn't switch 4. Sometimes we _do_ expect the tabs to switch. For example, apply a cross filter to a chart in 2nd tab from a chart in 1st tab. 5. Click on cross filter's name in filters badge in 2nd tab. 6. Verify that the tab switched and the source chart is highlighted ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/26262 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
