jessie-ross commented on issue #26390:
URL: https://github.com/apache/superset/issues/26390#issuecomment-1874925235

   > Note that even though the optional dependency name in Superset is called 
gsheets, the actual dependency is on the shillelagh package, instead of the old 
gsheets package, which does allow writing data to Google Sheets.
   
   Ah interesting, seems I got mixed up in my search, I think I did look into 
Shillelagh too and it seemed to unable to create a new sheet.
   
   > How hard do you think would it be to reuse the GSheetsEngineSpec.df_to_sql 
method in the [Google Sheets DB engine 
spec](https://github.com/apache/superset/blob/29633e7d8cad7b52669a9e6f5e064cd34da803a3/superset/db_engine_specs/gsheets.py#L340)
 instead of adding the gspread dependency?
   
   It looks like we aren't actually using Shillelagh, and are instead using 
it's internal requests session to make authenticated calls to the Google API 
directly, I can look into using this method, I would likely need to do some 
re-factoring with this code, and look into how using the Google Sheets engine 
authentication secrets for export would work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to