villebro commented on PR #26372: URL: https://github.com/apache/superset/pull/26372#issuecomment-1889697330
I suggest we introduce two new shared time sections for legacy charts: - one that works with temporal charts (=has time grain) - one that works with non-temporal charts Essentially these would be the same as `genericTime` and `legacyRegularTime`, but without the check for `hasGenericChartAxes`. These could then be used on legacy charts that don't want to support generic x-axis. These could then be removed once the last legacy chart has been removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
