jseparovic commented on issue #17269:
URL: https://github.com/apache/superset/issues/17269#issuecomment-1904929734

   The lat/long/zoom values are not being used as the initial set of values 
when the component loads. Instead the bounds are used to calculate the viewport.
   I've added a control setting to switch from this behavior "Auto" to using 
"Fixed" values based on the lat/long/zoom in the viewport settings.
   
![image](https://github.com/apache/superset/assets/4665758/13434f5c-3f4c-4b80-a18f-fda61371201d)
   
   I was also thinking that the setControlValue call should be saving the 
viewport settings when the map is dragged, so I thought an additional settings 
called "User" would be good to remember the User's dragged lat/long/zoom. 
However, it wasn't quite working as I expected and didn't seem to update the 
viewport settings properly.
   
   I also noticed that on first load after login, the plots show up ok on the 
map, but if you click to another dashboard and then back again, the plots do 
not show up until you drag the map. This was due to clusters not being tracked 
in react state. I updated the component to an FC and fixed this issue by add 
clusters to useState.
   
   There's still one more issue when looking at the world map and scanning left 
or right. When a plot disappears out of screen and then the same location shows 
up on the other side of the screen, the plot does not appear as soon as the 
location is visible.
   
   Here is the map I'm expecting:
   
![image](https://github.com/apache/superset/assets/4665758/8ae919d0-3cd6-4287-9d06-b5c3ed46409c)
   
   After dragging to the left:
   
![image](https://github.com/apache/superset/assets/4665758/26ad6610-e54c-4079-9866-9f3fb84d32cb)
   
   Looks like the plot calculation needs to be updated to fix this issue. 
Possibly to create duplicate plots so if the location is visible twice on the 
map, the plot shows up twice. This can happen when zooming all the way out.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to