betodealmeida commented on code in PR #26767:
URL: https://github.com/apache/superset/pull/26767#discussion_r1464065160
##########
superset/db_engine_specs/postgres.py:
##########
@@ -281,8 +281,9 @@ def get_default_schema_for_query(
This method simply uses the parent method after checking that there
are no
malicious path setting in the query.
"""
- sql = sqlparse.format(query.sql, strip_comments=True)
- if re.search(r"set\s+search_path\s*=", sql, re.IGNORECASE):
+ statement = SQLStatement(query.sql)
+ settings = statement.get_settings()
+ if "search_path" in settings:
Review Comment:
Look, ma! No regexes! 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
