craig-rueda commented on code in PR #26663:
URL: https://github.com/apache/superset/pull/26663#discussion_r1465329875


##########
helm/superset/templates/_helpers.tpl:
##########
@@ -61,6 +61,25 @@ Create chart name and version as used by the chart label.
   {{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | 
trimSuffix "-" -}}
 {{- end -}}
 
+{{/*
+Generate Redis URL for SSL and non-SSL protocols
+*/}}
+{{- define "superset-redis-url" -}}
+  {{- if .Values.supersetNode.connections.use_redis_ssl -}}
+    {{- if .Values.supersetNode.connections.redis_password -}}
+      
rediss://:{env('REDIS_PASSWORD')}@{env('REDIS_HOST')}:{env('REDIS_PORT')}/##DBNAME##?ssl_cert_reqs={{-
 .Values.supersetNode.connections.use_redis_ssl.ssl_cert_reqs | default 
"CERT_NONE" -}}
+    {{- else -}}
+      
rediss://{env('REDIS_HOST')}:{env('REDIS_PORT')}/##DBNAME##?ssl_cert_reqs={{- 
.Values.supersetNode.connections.use_redis_ssl.ssl_cert_reqs | default 
"CERT_NONE" -}}

Review Comment:
   You should be able to add more env keys here: 
https://github.com/apache/superset/blob/master/helm/superset/templates/secret-env.yaml#L32



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to