john-bodley commented on code in PR #26735:
URL: https://github.com/apache/superset/pull/26735#discussion_r1465361789
##########
superset/db_engine_specs/base.py:
##########
@@ -397,6 +397,9 @@ class BaseEngineSpec: # pylint:
disable=too-many-public-methods
# Can the catalog be changed on a per-query basis?
supports_dynamic_catalog = False
+ # Use column alias instead of aggregate function in GROUP BY
+ use_column_alias_in_groupby = False
Review Comment:
I'm surprised that the SQLAlchemy dialect doesn't handle this. The
[`visit_label`](https://github.com/sqlalchemy/sqlalchemy/blob/main/lib/sqlalchemy/sql/compiler.py#L2479-L2526)
method is likely relevant. Ideally we adopt the "shift left" mentality and
have the underlying dialect (rather than Superset) handle this logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
