john-bodley commented on code in PR #26467:
URL: https://github.com/apache/superset/pull/26467#discussion_r1465671421
##########
superset/db_engine_specs/presto.py:
##########
@@ -287,7 +287,7 @@ def convert_dttm(
if isinstance(sqla_type, types.Date):
return f"DATE '{dttm.date().isoformat()}'"
if isinstance(sqla_type, types.TIMESTAMP):
- return f"""TIMESTAMP '{dttm.isoformat(timespec="microseconds",
sep=" ")}'"""
+ return f"""TIMESTAMP '{dttm.isoformat(timespec="milliseconds",
sep=" ")}'"""
Review Comment:
@rusackas I think it's likely blocking as overtime it seems (as expected)
Presto and Trino are diverging. @zhaorui2022 would you mind making the change
in the `PrestoEngineSpec` and invoking the base class—via `super()`—where
appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
