mistercrunch commented on code in PR #26872:
URL: https://github.com/apache/superset/pull/26872#discussion_r1470401487
##########
.github/workflows/update-monorepo-lockfiles.yml:
##########
@@ -0,0 +1,39 @@
+name: Update Lockfiles for Dependabot Monorepo PRs
+
+on:
+ pull_request:
+ paths:
+ - 'superset-frontend/packages/**/package.json'
+ - 'superset-frontend/plugins/**/package.json'
+ # Trigger this workflow when Dependabot creates a pull request
+ types: [opened, synchronize, reopened]
Review Comment:
I'd say this should only trigger on `opened`, not the others. We don't want
it to trigger itself, even though I think `git push` should be a no-op when the
files does not change on the second run.
##########
.github/workflows/update-monorepo-lockfiles.yml:
##########
@@ -0,0 +1,39 @@
+name: Update Lockfiles for Dependabot Monorepo PRs
+
+on:
+ pull_request:
+ paths:
+ - 'superset-frontend/packages/**/package.json'
+ - 'superset-frontend/plugins/**/package.json'
+ # Trigger this workflow when Dependabot creates a pull request
+ types: [opened, synchronize, reopened]
+
+jobs:
+ update-lock-file:
+ runs-on: ubuntu-latest
+ if: github.event.pull_request.user.login == 'dependabot[bot]' # Ensure it
only runs for Dependabot PRs
+ defaults:
+ run:
+ working-directory: superset-frontend
+ steps:
+ - name: Checkout Code
+ uses: actions/checkout@v2
+ with:
+ ref: ${{ github.head_ref }} # Checkout the branch that made the PR
+
+ - name: Set up Node.js
+ uses: actions/setup-node@v2
+ with:
+ node-version: '16'
+
+ - name: Install Dependencies and Update Lock File
+ run: |
+ npm install
+
+ - name: Commit and Push Changes
+ run: |
+ git config user.name "GitHub-Actions[bot]"
+ git config user.email "github-actions[bot]@users.noreply.github.com"
+ git add package-lock.json
+ git commit -m "Update lock file for Dependabot PR" -a # Commit the
changes
+ git push # Push the changes back to the branch
Review Comment:
Assuming this is a no-op on the second run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
