fenilgmehta opened a new issue, #26882: URL: https://github.com/apache/superset/issues/26882
### Bug description SVG icons which have Apache Licence comment and XML tag result in the icon getting broken. Removing `<?xml version="1.0" encoding="UTF-8"?>` from those SVGs fixes the issue. The issue got introduced in https://github.com/apache/superset/pull/26857 Even GitHub is not able to render those SVGs (https://github.com/apache/superset/pull/26857/files#diff-ea23e99cde474e10690a62f28be5e102bb78ed0cd1e39612e96f0f4f1d48d380)  ### How to reproduce the bug 1. Visit https://superset.apache.org/ 2. Scroll down to `Supported Databases` section 3. Two icons are broken: `CSV` and `Apache Pinot` ### Screenshots/recordings  ### Superset version master / latest-dev ### Python version 3.9 ### Node version 16 ### Browser Chrome ### Additional context Search `<?xml version="1.0" encoding="UTF-8"` in the full repository and we will find many other SVG files which could get broken in future if comment (`<!-- ... -->`) is added to them, or which are already broken (e.g. `apache-hive.svg`) ### Checklist - [ ] I have searched Superset docs and Slack and didn't find a solution to my problem. - [X] I have searched the GitHub issue tracker and didn't find a similar bug report. - [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
