betodealmeida commented on code in PR #26989:
URL: https://github.com/apache/superset/pull/26989#discussion_r1478784637
##########
superset/daos/base.py:
##########
@@ -133,6 +133,7 @@ def create(
item: T | None = None,
attributes: dict[str, Any] | None = None,
commit: bool = True,
+ add: bool = True,
Review Comment:
I'm concerned about this, because from my understanding this shouldn't be
the issue, and I'm worried that we're introducing a pattern that would cause
more subtle bugs.
Can we implement this only in `DatabaseDAO.create`, and only for the SSH
tunnel case? (ie, don't make it a parameter)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
