brouberol commented on PR #26782:
URL: https://github.com/apache/superset/pull/26782#issuecomment-1932630843
I've rebase on upstream `master` and ran `pre-commit run -a` locally, which
passed:
```console
~/wmf/apache/superset fix-25636 ⇣1⇡152 ❯ pre-commit run -a
auto-walrus..............................................................Passed
pyupgrade................................................................Passed
pycln....................................................................Passed
isort....................................................................Passed
mypy.....................................................................Passed
pip-compile-multi
verify.................................................Passed
check docstring is
first.................................................Passed
check for added large
files..............................................Passed
check
yaml...............................................................Passed
debug statements
(python)................................................Passed
fix end of
files.........................................................Passed
trim trailing
whitespace.................................................Passed
black....................................................................Passed
prettier.................................................................Passed
Blacklist................................................................Passed
Helm
Docs................................................................Passed
```
So did running the associated unit tests:
```console
~/wmf/apache/superset fix-25636 ❯ pytest
tests/unit_tests/db_engine_specs/test_{presto,trino}.py --disable-warnings
=====================================================================================================
test session starts
=======================================================================
platform darwin -- Python 3.9.18, pytest-7.3.1, pluggy-1.2.0
rootdir: /Users/br/wmf/apache/superset
configfile: pytest.ini
plugins: pyfakefs-5.2.2, mock-3.10.0, cov-4.0.0
collected 62 items
tests/unit_tests/db_engine_specs/test_presto.py .................
tests/unit_tests/db_engine_specs/test_trino.py
.............................................
=====================================================================================================
62 passed in 0.54s
========================================================================
~/wmf/apache/superset fix-25636 ❮
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
