geido commented on PR #27029: URL: https://github.com/apache/superset/pull/27029#issuecomment-1934122489
> @geido I _think_ drill by needs the can_explore permission only for the "Edit chart" button. If we made that button conditionally disabled if user doesn't have access to Explore and sent the post request in line 90 in `DrillByModal.tsx`, then the feature _should_ work just fine without `can_explore`. That would solve the issues that @sfirke linked in his comment That's right. Drill by does not need `can_explore`. However, removing `can_explore` would cause Drill by to show up and it might not be the expected behaviour for most people at this point. I think having granular permissions for both Drill by and Drill to detail could be a better approach to remove the dependency on `can_explore`. @yousoph what do you think? I would aim to merge this PR as it is and continue in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
