cgivre commented on code in PR #27073:
URL: https://github.com/apache/superset/pull/27073#discussion_r1488574784
##########
superset/db_engine_specs/drill.py:
##########
@@ -117,3 +120,23 @@ def get_url_for_impersonation(
)
return url
+
+ @classmethod
+ def fetch_data(
+ cls,
+ cursor: Any,
+ limit: int | None = None,
+ ) -> list[tuple[Any, ...]]:
+ """
+ Custom `fetch_data` for Drill.
+
+ When no rows are returned, Drill raises a `RuntimeError` with the
message
Review Comment:
@john-bodley I'm one of the authors of the Drill SQLAlchemy dialect. It's
been a few years however, so I don't remember much about how it works. If
something should be fixed there, I'm happy to do it. However, could someone
please explain what the exact issue is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
