mistercrunch commented on a change in pull request #6959: bugfix: improve 'Time
Table'
URL:
https://github.com/apache/incubator-superset/pull/6959#discussion_r274760267
##########
File path: superset/assets/src/SqlLab/components/ExploreResultsButton.jsx
##########
@@ -141,7 +141,9 @@ class ExploreResultsButton extends React.PureComponent {
// open new window for data visualization
exportChart(formData);
})
- .catch(() => {
+ .catch((e) => {
+ /* eslint no-console: 0 */
+ console.error(e);
Review comment:
I did, but after reading a bit about best practices, I removed it...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
