zhaoyongjie commented on code in PR #27144:
URL: https://github.com/apache/superset/pull/27144#discussion_r1494362502
##########
superset/common/utils/query_cache_manager.py:
##########
@@ -145,7 +145,7 @@ def get(
Initialize QueryCacheManager by query-cache key
"""
query_cache = cls()
- if not key or not _cache[region] or force_query:
+ if not key or not _cache[region] or not force_query:
Review Comment:
@GAlexeyV, the default value of force_query is False(the frontend side also
emit **false** as force_query), and the **not force_query** condition in **or**
expression means that all of default queries(except true as force_query) emit
to Superset should create a **new query_cache** object --- please don't use
cached data.
It is an opposite behavior to we're expected, what is the expected behavior
before? 1. if the data cached 2. and the force_query is False 3. then the query
should been responded by the Cache.
You could set a stop debugger at line 149 to verify this situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
