pradasouvanlasy commented on code in PR #27163:
URL: https://github.com/apache/superset/pull/27163#discussion_r1496333392


##########
helm/superset/values.yaml:
##########
@@ -248,6 +248,8 @@ supersetNode:
     maxReplicas: 100
     targetCPUUtilizationPercentage: 80
     # targetMemoryUtilizationPercentage: 80
+  # -- Sets the [pod disruption 
budget](https://kubernetes.io/docs/tasks/run-application/configure-pdb/) for 
supersetNode pods

Review Comment:
   I've made the changes and slightly refactored the PDB templates I'm 
contributing there to make better use of variable scoping - reducing a bit the 
boilerplate and avoiding to repeat `.Values.supersetXXX.podDisruptionBudget` 
everywhere.
   
   Please tell me if the updated documentation looks clear enough as well. 
Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to