fisjac commented on PR #19844: URL: https://github.com/apache/superset/pull/19844#issuecomment-1957631226
I think it would be preferrable to have the a timestamp config variable as a boolean and move the timestamp generation logic to where the email/slack is being generated. Also, I believe we should be applying the same naming convention to all attachment types (csv, png, and pdf on the frontend). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
