nigzak commented on code in PR #27187:
URL: https://github.com/apache/superset/pull/27187#discussion_r1500842382
##########
requirements/base.txt:
##########
@@ -90,6 +90,8 @@ dnspython==2.1.0
# via email-validator
email-validator==1.1.3
# via flask-appbuilder
+exceptiongroup==1.2.0
+ # via cattrs
Review Comment:
I don't know where this comes from, I did not change something else?
I made a re-sync with the master and run it again, it still appears in my
output?
If I am looking to the package "cattrs" it seems it is a mandatory
requirement and it should be there?
I can also manual remove it if it is not good?
https://github.com/apache/superset/blob/master/requirements/base.txt
```
cattrs==23.2.1
# via requests-cache
```
if I check this package local it says that exceptiongroup is a mandatory
sub-dependency?
```
....pip show cattrs
Name: cattrs
Version: 23.2.1
Summary: Composable complex class support for attrs and dataclasses.
Home-page:
Author:
Author-email: Tin Tvrtkovic <tinches...@gmail.com>
License: MIT
Location: /home/starnol/.local/lib/python3.10/site-packages
Requires: attrs, exceptiongroup, typing-extensions
Required-by:
```
```
other way around:
... pip show exceptiongroup
Name: exceptiongroup
Version: 1.1.3
Summary: Backport of PEP 654 (exception groups)
Home-page:
Author:
Author-email: Alex Grönholm <alex.gronh...@nextday.fi>
License:
Location: /home/starnol/.local/lib/python3.10/site-packages
Requires:
Required-by: cattrs, trio, trio-websocke
```
shall i still remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
