dvchristianbors commented on PR #19572: URL: https://github.com/apache/superset/pull/19572#issuecomment-1980276699
> @dvchristianbors, @betodealmeida recently introduced [[SIP-117] Improve SQL parsing](https://github.com/apache/superset/issues/26786) which proposes that we use `sqlglot` for all of our SQL parsing. Rather than disabling the `sqlparse` calls (which likely serve some purpose) to improve query performance, would you mind trying `sqlglot` instead? I replaced the usage of sqlparse with sqlglot for splitting up multiple sql statements. However, sqlglot does not include the formatting function that was specifically removed due to performance issues here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
