mistercrunch commented on code in PR #27434: URL: https://github.com/apache/superset/pull/27434#discussion_r1518046294
########## docker-compose-non-dev.yml: ########## @@ -23,6 +22,12 @@ x-superset-volumes: - ./docker:/app/docker - superset_home:/app/superset_home +x-common-build: &common-build + context: . + target: dev + cache_from: + - apache/superset-cache:3.9-slim-bookworm Review Comment: Anything that uses `scripts/build_docker.py` (a cli that wraps the docker build CLI) will use the `cache-from`, and `cache-to`, but can only push if it's logged in (push or pull_request against the main repo). Currently I think all the GitHub actions that build images (`pull_request` , `push` on master and releases) will use this thing and hopefully use the cache. Docker-compose can piggy backing on this cache here that should really speed up the builds since in most case most layers can be re-used from the `master` builds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
