eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1483744360
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/editmode.test.ts:
##########
@@ -483,51 +483,6 @@ describe('Dashboard edit', () => {
selectColorScheme('lyftColors');
applyChanges();
saveChanges();
-
- // open nested tab
- openTab(1, 1);
- waitForChartLoad({
- name: 'Top 10 California Names Timeseries',
- viz: 'line',
- });
-
- // label Anthony
- cy.get(
- '[data-test-chart-name="Top 10 California Names Timeseries"] .line
.nv-legend-symbol',
- )
- .first()
- .should('have.css', 'fill', 'rgb(51, 61, 71)');
-
- // open 2nd main tab
- openTab(0, 1);
- waitForChartLoad({ name: 'Trends', viz: 'line' });
-
- // label Anthony
- cy.get('[data-test-chart-name="Trends"] .line .nv-legend-symbol')
- .eq(2)
- .should('have.css', 'fill', 'rgb(51, 61, 71)');
-
- editDashboard();
- openProperties();
- selectColorScheme('bnbColors');
- applyChanges();
- saveChanges();
-
- // label Anthony
- cy.get('[data-test-chart-name="Trends"] .line .nv-legend-symbol')
- .eq(2)
- .should('have.css', 'fill', 'rgb(244, 176, 42)');
-
- // open main tab and nested tab
- openTab(0, 0);
- openTab(1, 1);
-
- // label Anthony
- cy.get(
- '[data-test-chart-name="Top 10 California Names Timeseries"] .line
.nv-legend-symbol',
- )
- .first()
- .should('have.css', 'fill', 'rgb(244, 176, 42)');
Review Comment:
I'm just testing what's actually breaking in this file. Will revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
