michael-s-molina commented on code in PR #27442:
URL: https://github.com/apache/superset/pull/27442#discussion_r1521921799
##########
superset/common/query_actions.py:
##########
@@ -154,6 +153,7 @@ def _get_samples(
qry_obj_cols.append(o.get("column_name"))
else:
qry_obj_cols.append(o.column_name)
+ query_obj.orderby = [(query_obj.columns[0], True)]
Review Comment:
I don't have much context here but given that we're explicitly setting:
```
query_obj.orderby = []
query_obj.metrics = None
```
and that the definition of `OrderBy` is:
```
OrderBy = tuple[Metric, bool]
```
Setting the order by to the first column might not be the correct answer
given that it only accepts ordering by metric which is explicitly being set to
empty. Maybe @zhaoyongjie or @villebro have more context and can help us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
