rusackas commented on code in PR #24449:
URL: https://github.com/apache/superset/pull/24449#discussion_r1521967561
##########
superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx:
##########
@@ -140,16 +256,52 @@ class RefreshIntervalModal extends React.PureComponent<
}
modalFooter={
<>
+ <Button onClick={this.onCancel} buttonSize="small">
+ {t('Cancel')}
+ </Button>
<Button
buttonStyle="primary"
buttonSize="small"
- onClick={this.onSave}
+ onClick={() => {
Review Comment:
It would be better if handlers called an external function rather than
defining the logic inline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
