PenneyHuang commented on PR #22604:
URL: https://github.com/apache/superset/pull/22604#issuecomment-1993375169
ok,thanks.From the perspective of implementation effect, achieving the goal
is sufficient
------------------ 原始邮件 ------------------
发件人:
"apache/superset"
***@***.***>;
发送时间: 2024年3月13日(星期三) 凌晨5:44
***@***.***>;
***@***.******@***.***>;
主题: Re: [apache/superset] feat(chart): Add a configuration item to
configure links for table (PR #22604)
Why hasn't it been merged yet
Two main reasons:
Beause the PR is in need of a rebase
because there's an open question about whether we'd want to add these links
here (in the chart builder) or closer to the root, in the datasource editor /
semantic layer
Because you can already do this with an ad-hoc column in the chart builder,
OR via a calculated column in the dataset editor, so this handy yet potentially
redundant
It's cool, but it needs more design/product review. CC @yousoph @kasiazjc
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
