villebro commented on code in PR #27487:
URL: https://github.com/apache/superset/pull/27487#discussion_r1522486658
##########
superset/utils/pandas_postprocessing/resample.py:
##########
@@ -43,13 +43,16 @@ def resample(
raise InvalidPostProcessingError(_("Resample operation requires
DatetimeIndex"))
if method not in RESAMPLE_METHOD:
raise InvalidPostProcessingError(
- _("Resample method should in ") + ", ".join(RESAMPLE_METHOD) + "."
+ _("Resample method should be in ") + ", ".join(RESAMPLE_METHOD) +
"."
)
if method == "asfreq" and fill_value is not None:
_df = df.resample(rule).asfreq(fill_value=fill_value)
+ _df = _df.fillna(fill_value)
elif method == "linear":
_df = df.resample(rule).interpolate()
else:
_df = getattr(df.resample(rule), method)()
+ if method in ("ffill", "bfill"):
+ _df = _df.fillna(method=method)
Review Comment:
Check the docs for using `fillna` with `method`:
https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.core.resample.Resampler.fillna.html#pandas.core.resample.Resampler.fillna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
