rusackas commented on issue #25459: URL: https://github.com/apache/superset/issues/25459#issuecomment-1997799385
Oh, you're right, EMAIL_NOTIFICATIONS isn't really _used_ anywhere. Seems like @sfirke has also taken a closer look at this than I have... not sure what we need to do here. I'll leave this open until one one of your PRs merges (or one like it), but otherwise, would it be fair to just delete `EMAIL_NOTIFICATIONS` if it's vestigial code? Seems like it'd be a non-breaking change to do so, and might be an easier way to close this issue :P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
