JurajBurian commented on issue #27177:
URL: https://github.com/apache/superset/issues/27177#issuecomment-1999867912

   > It would be helpful if folks here could check if the issue persists after 
#27484 as @JurajBurian mentioned 
[here](https://github.com/apache/superset/pull/27484#issuecomment-1997081002). 
It would be helpful to determine if it's only a specific case that's still 
failing or if there are others. Given the nature of the bug, please provide as 
much detail as possible.
   
   I patched latest docker image (and also manager.py looks as actual in 
master) and I believe that first change in my patch was correct. I replaced 
return True on  False on the line 158 in sanity check:
   
   ```Python
       # sanity checks
       if form_data is None or stored_chart is None:
           return False
   ```
   this is probably correct, because in same case one (or maybe both) of values 
is None in the condition. And this patch was almost "correct", but for some 
cases then type cast exception occured - as I mentioned in my remark. 
   I hope that my observation help fix this bug.
   For now we use almost<sup>1</sup>  absolutely fresh image from master (fixed 
other bugs ) on production :-(.  
   
   1) Latest image has another problem:  some selects written in PostgreSQL 
dialect throw exception [see my remark on 
slack](https://apache-superset.slack.com/archives/C016B3LG5B4/p1710430195538299).
 @michael-s-molina should I raise an issue about this problem? Sorry if it is 
not a good place to ask question like this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to