justinpark opened a new pull request, #27539: URL: https://github.com/apache/superset/pull/27539
### SUMMARY Airbnb had previously overridden an option to disable ad-hoc metrics with commit #17202. However, with the D&D option now enabled, users can accidentally drop an ad-hoc metric, thus gaining access to the previously disabled (tab) option. To address this, the commit includes a condition to check whether the item being dropped is among the saved metrics, preventing such cases. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://github.com/apache/superset/assets/1392866/00519a56-9218-4847-b678-0498f39be6bf After: https://github.com/apache/superset/assets/1392866/eee213ce-d3ce-44c4-a608-d2a4cc88b771 ### TESTING INSTRUCTIONS Set a dataset extra with `{ "disallow_adhoc_metrics": true }' Create a chart with the dataset and then try to drop a column to "Metric" which should be blocked ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
