michael-s-molina commented on code in PR #27644: URL: https://github.com/apache/superset/pull/27644#discussion_r1539968925
########## superset/models/sql_lab.py: ########## @@ -76,7 +77,7 @@ def sql_tables(self) -> list[Table]: self.database.db_engine_spec.engine, # type: ignore ) ) - except SupersetSecurityException: + except (SupersetSecurityException, TemplateError): Review Comment: I just noticed that FlaskAppBuilder does not expect models to throw an error when accessing its properties. We'll probably won't be able to fix this without changing FlaskAppBuilder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org