john-bodley commented on code in PR #27779:
URL: https://github.com/apache/superset/pull/27779#discussion_r1544724981
##########
superset-frontend/src/dashboard/util/permissionUtils.ts:
##########
@@ -25,16 +25,14 @@ import {
import { Dashboard } from 'src/types/Dashboard';
import { findPermission } from 'src/utils/findPermission';
-// this should really be a config value,
-// but is hardcoded in backend logic already, so...
-const ADMIN_ROLE_NAME = 'admin';
+const ADMIN_ROLE_NAME = window.adminRole || 'Admin';
Review Comment:
See https://github.com/apache/superset/pull/27779/files#r1544723819 as to
why this will _always_ be set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
