jessie-ross commented on code in PR #27777:
URL: https://github.com/apache/superset/pull/27777#discussion_r1545358461
##########
superset/utils/logging_configurator.py:
##########
@@ -41,19 +41,11 @@ def configure_logging(
if app_config["SILENCE_FAB"]:
logging.getLogger("flask_appbuilder").setLevel(logging.ERROR)
- # configure superset app logger
- superset_logger = logging.getLogger("superset")
- if debug_mode:
- superset_logger.setLevel(logging.DEBUG)
- else:
- # In production mode, add log handler to sys.stderr.
- superset_logger.addHandler(logging.StreamHandler())
- superset_logger.setLevel(logging.INFO)
-
- logging.getLogger("pyhive.presto").setLevel(logging.INFO)
Review Comment:
I was guessing this line was put in place due to too many `DEBUG` level logs
coming from `pyhive.presto`, due to having a default root log level of `DEBUG`
- which I'm guessing is by accident after looking at this file.
By setting the default `LOG_LEVEL` to `INFO` it becomes redundant.
I'm happy to put it back if that's not the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
