eulloa10 commented on code in PR #26602:
URL: https://github.com/apache/superset/pull/26602#discussion_r1558772499
##########
superset-frontend/src/explore/components/controls/FixedOrMetricControl/index.jsx:
##########
@@ -127,7 +127,7 @@ export default class FixedOrMetricControl extends
React.Component {
<Collapse.Panel
showArrow={false}
header={
- <Label onClick={() => undefined}>
Review Comment:
This was introduced as part of a migration from Bootstrap to AntD components
in this
[PR](https://github.com/apache/superset/pull/12920/files#diff-a7be32a17ea0cae5c0409a1c8ef7abd669132a56052f97a24aac78570f074cef).
However, there doesn't seem to be additional context as to why this `onClick`
is returning `undefined`. Should we leave it as is and not remove the `onClick`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
