soniagtm opened a new pull request, #27969:
URL: https://github.com/apache/superset/pull/27969

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Currently, the platform renders any HTML command in the result table, which 
can sometimes obscure the full HTML in the request body. To address this, an 
option button that enables users to control the rendering of HTML in the result 
table is added. This option would provide users with more flexibility and 
clarity when viewing HTML content within SQLLab, as well as in table chart. 
This addition is also discussed in [this lazy 
consensus](https://lists.apache.org/thread/1y4rxnply1m7xonnwro2b12f276vc2hm).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   **Before** 
   
   _**SQL Lab**_
   <img width="1791" alt="Screenshot 2567-04-10 at 15 35 32" 
src="https://github.com/apache/superset/assets/96282005/e8cccbb6-4ec3-4707-9be1-5bef8a1be720";><br/>
   _**Table Chart**_
   <img width="1791" alt="Screenshot 2567-04-10 at 15 36 02" 
src="https://github.com/apache/superset/assets/96282005/a5a0ac1a-cf23-42e1-afa6-f3e28b2a8c18";>
   
   **After**
   
   _**SQL Lab**_
   
   
https://github.com/apache/superset/assets/96282005/b8e5161c-c7bb-4c72-b977-277cf52de259
   
   
   _**Table Chart**_
   
   
https://github.com/apache/superset/assets/96282005/24c58851-c461-4b7d-bd47-49b9436b576b
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   **SQL Lab**
   1. Enter a query that contains an HTML string.
   2. Press the "Run" button.
   3. The result should be rendered as HTML.
   4. Try disabling the "Render HTML" option.
   5. Run the query again.
   6. The result should be rendered as a normal string.
   
   **Table Chart**
   1. Create a table chart with the column that contains HTML strings.
   2. The result should be rendered as HTML.
   3. Uncheck the "Render columns in HTML format" option in Customize panel.
   4. Update the chart.
   5. The result should be rendered as a normal string.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [X] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to