eschutho commented on code in PR #27899:
URL: https://github.com/apache/superset/pull/27899#discussion_r1560137869
##########
superset/models/core.py:
##########
@@ -376,9 +407,7 @@ def get_effective_user(self, object_url: URL) -> str | None:
return (
username
if (username := get_username())
- else object_url.username
- if self.impersonate_user
- else None
+ else object_url.username if self.impersonate_user else None
Review Comment:
```suggestion
else object_url.username
if self.impersonate_user
else None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
