eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1561871095


##########
superset-frontend/src/dashboard/types.ts:
##########
@@ -237,3 +237,32 @@ export type Slice = {
   owners: { id: number }[];
   created_by: { id: number };
 };
+
+export enum MenuKeys {
+  DownloadAsImage = 'download_as_image',
+  ExploreChart = 'explore_chart',
+  ExportCsv = 'export_csv',
+  ExportFullCsv = 'export_full_csv',
+  ExportXlsx = 'export_xlsx',
+  ExportFullXlsx = 'export_full_xlsx',
+  ForceRefresh = 'force_refresh',
+  Fullscreen = 'fullscreen',
+  ToggleChartDescription = 'toggle_chart_description',
+  ViewQuery = 'view_query',
+  ViewResults = 'view_results',
+  DrillToDetail = 'drill_to_detail',
+  CrossFilterScoping = 'cross_filter_scoping',
+  Share = 'share',
+  ShareByEmail = 'share_by_email',
+  CopyLink = 'copy_link',
+  Download = 'download',
+  SaveModal = 'save_modal',
+  RefreshDashboard = 'refresh_dashboard',
+  AutorefreshModal = 'autorefresh_modal',
+  SetFilterMapping = 'set_filter_mapping',
+  EditProperties = 'edit_properties',
+  EditCss = 'edit_css',
+  ToggleFullscreen = 'toggle_fullscreen',
+  ManageEmbedded = 'manage_embedded',
+  ManageEmailReports = 'manage_email_reports',
+}

Review Comment:
   I thought maybe this file was only to be used for typescript types rather 
than runtime enums. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to