mtrentz opened a new pull request, #28038: URL: https://github.com/apache/superset/pull/28038
### SUMMARY Previously when the value of a BigNumber was zero (falsey) the expression to evaluate colors always got evaluated to false. Meaning that if my condition was `number <= 50` and my number was 0, it wouldn't color it. It would work if it was `0.1`. Related to this issue: #21820 Most recent discussion around this PR #23064 ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - Tested if colors when BigNumber is zero - Tested if still works for negative, floats, and scientific notation numbers like `1e-100` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
