rusackas commented on code in PR #28054:
URL: https://github.com/apache/superset/pull/28054#discussion_r1567668730
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -590,7 +591,12 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsWithRouter) => {
case MenuKeys.ExploreChart:
// eslint-disable-next-line no-unused-expressions
props.logExploreChart?.(props.slice.slice_id);
- window.open(props.exploreUrl);
+ if (domEvent.metaKey || domEvent.ctrlKey) {
Review Comment:
A few questions here:
1) Are we sure this works for mac and PC browsers as expected? Seems like it
should, but ¯\\\_(ツ)_/¯
2) Do we need tests to prevent this regressing again?
3) Is there a reason we can't just use an HTML link here? I feel like we had
that solved at one point.
4) Is it not amazing that this particular link has been the subject of like
20 PRs and Issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
