eschutho commented on code in PR #25785:
URL: https://github.com/apache/superset/pull/25785#discussion_r1568006394
##########
superset/models/helpers.py:
##########
@@ -875,7 +875,9 @@ def mutate_query_from_config(self, sql: str) -> str:
"""Apply config's SQL_QUERY_MUTATOR
Typically adds comments to the query with context"""
- if sql_query_mutator := config["SQL_QUERY_MUTATOR"]:
+ if (sql_query_mutator := config.get("SQL_QUERY_MUTATOR")) and not
config.get(
+ "MUTATE_AFTER_SPLIT"
Review Comment:
@john-bodley I'm circling back to this old PR to see if I can get it merged.
Do you think this statement needs to be removed? I copied it over from
`superset/connectors/sqla/models.py` when drying up this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
