kgabryje commented on code in PR #27891:
URL: https://github.com/apache/superset/pull/27891#discussion_r1568679515
##########
superset-frontend/src/components/AlteredSliceTag/index.tsx:
##########
@@ -235,39 +233,35 @@ class AlteredSliceTag extends React.Component<
return (
<TableView
columns={columns}
- data={this.state.rows}
+ data={rows}
pageSize={50}
className="table-condensed"
columnsForWrapText={columnsForWrapText}
/>
);
- }
+ }, [rows]);
- renderTriggerNode(): React.ReactNode {
- return (
+ const renderTriggerNode = useCallback(
Review Comment:
this too:
```suggestion
const triggerNode = useMemo(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
