john-bodley commented on code in PR #28159:
URL: https://github.com/apache/superset/pull/28159#discussion_r1573402338
##########
tests/integration_tests/charts/api_tests.py:
##########
@@ -82,121 +83,115 @@ class TestChartApi(ApiOwnersTestCaseMixin,
InsertChartMixin, SupersetTestCase):
resource_name = "chart"
@pytest.fixture(autouse=True)
- def clear_data_cache(self):
- with app.app_context():
- cache_manager.data_cache.clear()
- yield
+ def clear_data_cache(self, app_context: AppContext):
Review Comment:
Reuse existing fixture. That said I'm not entirely sure why it's needed
given it's in a class derived from Flask-Testing's `TestCase` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
