michael-s-molina commented on code in PR #28153:
URL: https://github.com/apache/superset/pull/28153#discussion_r1576900143
##########
superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.ts:
##########
@@ -55,10 +55,23 @@ const getHelperText = (value: string) =>
docText: value,
};
+const extensionsRegistry = getExtensionsRegistry();
+
+const useDefaultCustomKeywords = () => ({ data: undefined });
+
export function useKeywords(
{ queryEditorId, dbId, schema }: Params,
skip = false,
) {
+ const useCustomKeywords =
Review Comment:
Can we instantiate customKeywords as an empty array that is overridden when
`sqleditor.extension.customAutocomplete` is defined?
##########
superset-frontend/packages/superset-ui-core/src/ui-overrides/types.ts:
##########
@@ -164,6 +165,26 @@ export interface SubMenuProps {
activeChild?: string;
}
+export interface CustomAutoCompleteArgs {
+ queryEditorId: string;
+ dbId?: string | number;
+ schema?: string;
+}
+
+interface AutocompleteItem {
+ name: string;
+ value: string;
+ score: number;
+ meta: string;
+ label?: string;
+ docHTML?: string | undefined;
+ docText?: string | undefined;
Review Comment:
```suggestion
docHTML?: string;
docText?: string;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
