betodealmeida commented on code in PR #28205:
URL: https://github.com/apache/superset/pull/28205#discussion_r1580151313
##########
superset/security/manager.py:
##########
@@ -409,15 +409,16 @@ def can_access_all_datasources(self) -> bool:
:returns: Whether the user can access all the datasources
"""
- return self.can_access("all_datasource_access",
"all_datasource_access")
+ return self.can_access_all_databases() or self.can_access(
+ "all_datasource_access", "all_datasource_access"
+ )
Review Comment:
@eschutho mentioned the case where we want to give someone access to all the
tables for them to query in SQL Lab, but we don't want them modifying the
database configuration. In that case, we'd want them to have
`all_datasource_access` but not `all_database_access`, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
